initial small changes to add returns_id attribute to APOSMM class#1646
Merged
jlnav merged 1 commit intoexperimental/jlnav_plus_shuds_asktellfrom Jan 8, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## experimental/jlnav_plus_shuds_asktell #1646 +/- ##
=========================================================================
- Coverage 58.37% 58.37% -0.01%
=========================================================================
Files 80 80
Lines 8125 8127 +2
Branches 1234 1235 +1
=========================================================================
+ Hits 4743 4744 +1
Misses 3099 3099
- Partials 283 284 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jlnav
merged commit e3f2375
into
experimental/jlnav_plus_shuds_asktell
28 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm assuming that if-and-only-if generators return IDs that we'll want to map those to sim_ids. But what other conditions do we have to account for?
What behavior changes does libE still need, depending on if a gen returns IDs or not?